Stefan Beller <sbeller@xxxxxxxxxx> writes: >> * jt/remove-pack-bitmap-global (2018-06-21) 2 commits >> - pack-bitmap: add free function >> - pack-bitmap: remove bitmap_git global variable >> >> The effort to move globals to per-repository in-core structure >> continues. > > This is mostly done, though Peff seems to expect a reroll with > clarification on how the series is structured? > https://public-inbox.org/git/20180611211033.GB26235@xxxxxxxxxxxxxxxxxxxxx/ That one has been resolved by squashing the updated log message in, I think, so we should be able to merge it down. >> * sb/submodule-move-head-error-msg (2018-06-25) 1 commit >> - submodule.c: report the submodule that an error occurs in >> >> Needs a reroll. >> cf. <20180622081713.5360-1-szeder.dev@xxxxxxxxx> > > https://public-inbox.org/git/xmqqmuviq2n7.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx/ > > suggests that you applied that change and a reroll would not be needed. Yup, I forgot about that one. Thanks. > It is easy to quantify how often we are bitten by code churn > (that you call useless here); and very hard to quantify bugs By definition, churn is useless. Useful ones are refactoring ;-). And when you do want to operate on _the_ single in-core instance, not having to say &the_index in the argument and use $foo_cache() function does *not* become a source of "bugs". It just saves typing, and turning it to $foo_index(&the_index,...) does *not* make it less error prone. >> * sb/diff-color-move-more (2018-06-25) 11 commits >> - diff: fix a sparse 'dubious one-bit signed bitfield' error >> - SQUASH??? t/4015 GETTEXT_POISON emergency fix >> - SQUASH????? Documentation breakage emergency fix > [...] >> >> "git diff --color-moved" feature has further been tweaked. >> >> Needs to be cleaned-up with various fix-up bits applied inline. > > I'll resend with those squashes and another (test-)fix SZEDER > mentioned soon. The interdiff of the topic looked alright. Thanks.
