On Thu, Jun 28, 2018 at 06:23:56PM +0200, Johannes Schindelin wrote: > On Thu, 28 Jun 2018, Jeff King wrote: > > > On Wed, Jun 27, 2018 at 09:35:23PM +0200, Johannes Schindelin via GitGitGadget wrote: > > > > > To prevent erroneous commits from being reported (e.g. when unpacking > > > Git's source code from a .tar.gz file into a subdirectory of a different > > > Git project, as e.g. git_osx_installer does), we painstakingly set > > > GIT_CEILING_DIRECTORIES when trying to determine the current commit. > > > > > > Except that we got the quoting wrong, and that variable therefore does > > > not have the desired effect. > > > > > > Let's fix that quoting, and while at it, also suppress the unhelpful > > > message > > > > I had to stare at the code for a bit to figure out what was wrong: > > Do you want me to update the commit message? I'm OK either way. Probably not worth a re-roll unless you want to be completionist about commit messages (personally I do not mind occasionally jumping to the list archive to get historical context and reviews). -Peff
