Hi Paul, as a general rule, we try to keep the commit subjects in the imperative, i.e. sha1-name.c: add 'get_oidf', which acts like 'get_oid' On Mon, 25 Jun 2018, Paul-Sebastian Ungureanu wrote: > Compared to 'get_oid', 'get_oidf' has as parameters a > printf format string and the additional arguments. This > will help simplify the code in subsequent commits. Good. The patch is obviously correct, from my perspective. Ciao, Dscho