Hi Junio & Alban, On Mon, 25 Jun 2018, Junio C Hamano wrote: > * ag/rebase-i-append-todo-help (2018-06-14) 2 commits > - rebase--interactive: rewrite append_todo_help() in C > - Merge branch 'ag/rebase-p' into ag/rebase-i-append-todo-help > (this branch is used by ag/rebase-i-rewrite-todo.) > > Stepwise rewriting of the machinery of "rebase -i" into C continues. I just reviewed this on GitHub (which gives me an interactive way to look around outside of the diff context) and I think there are two things left to do (which I mentioned to Alban on IRC): - `msg = _(...)` should be `msg = N_(...)` instead, with the corresponding `_(msg)` later on, and - to avoid cluttering sequencer.c, and to pave the way for future `rebase -i`-specific code, the `append_todo_help()` function should go into a new file called `interactive-rebase.c`. Ciao, Dscho
