On Mon, Jun 25, 2018 at 10:35 AM Derrick Stolee <stolee@xxxxxxxxx> wrote:
> diff --git a/midx.c b/midx.c
> @@ -210,6 +227,20 @@ static void sort_packs_by_name(char **pack_names, uint32_t nr_packs, uint32_t *p
> +static size_t write_midx_pack_lookup(struct hashfile *f,
> + char **pack_names,
> + uint32_t nr_packs)
> +{
> + uint32_t i, cur_len = 0;
> +
> + for (i = 0; i < nr_packs; i++) {
> + hashwrite_be32(f, cur_len);
> + cur_len += strlen(pack_names[i]) + 1;
> + }
> +
> + return sizeof(uint32_t) * (size_t)nr_packs;
> +}
This static function is never used, thus breaks the build with DEVELOPER=1:
midx.c:567:15: error: ‘write_midx_pack_lookup’ defined but not used
[-Werror=unused-function]
cc1: all warnings being treated as errors
