Re: [PATCH v3 2/8] upload-pack: implement ref-in-want

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/25, Jonathan Tan wrote:
> > +static int parse_want_ref(const char *line, struct string_list *wanted_refs)
> > +{
> > +	const char *arg;
> > +	if (skip_prefix(line, "want-ref ", &arg)) {
> > +		struct object_id oid;
> > +		struct string_list_item *item;
> > +		struct object *o;
> > +
> > +		if (read_ref(arg, &oid))
> > +			die("unknown ref %s", arg);
> 
> One more thing - if you're planning to "die" here, also write out an
> error to the user, just like in parse_want().

Oh good idea, I'll add an ERR pkt here

-- 
Brandon Williams



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux