On 06/22, Antonio Ospite wrote: > On Fri, 22 Jun 2018 10:13:10 -0700 > Brandon Williams <bmwill@xxxxxxxxxx> wrote: > > [...] > > Thanks for working on this. I think its a good approach and the end > > result makes it much harder for arbitrary config to sneak back in to the > > .gitmodules file. And after this series it looks like you should be in > > a good place to read the .gitmodules file from other places (not just in > > the worktree). > > > > :) > > > As you've mentioned here I also agree we could do without the last patch > > but I'll leave that up to you. Other than a couple typos I found I > > think this series looks good! Thanks again for revisiting this. > > > > Thanks for the review. > > I understand your compromise solution for patch 7, but I'd say let's > keep it simple and just drop patch 7 for now. Yeah that's probably the best approach for the time being. > > I am going to wait a couple of days and then send a v2. Perfect, thanks again! -- Brandon Williams
