On 6/21/2018 6:39 PM, Jonathan Tan wrote:
Both this and the previous patch look good to me; you seem to have better (stricter) checking for missing includes/forward declarations, am I missing a compile option? (I have DEVELOPER=1 in config.mak)Thanks. No I don't - I discovered that these were missing as I was including these header files in other files.
I discovered similar missing headers in object-store.h while reworking the MIDX patch series. Thanks for fixing them here!