On Tue, Jun 19, 2018 at 04:53:10PM -0400, Jeff King wrote: > On Tue, Jun 19, 2018 at 10:40:16PM +0200, Torsten Bögershausen wrote: > > > > > > > On 06/19/2018 08:22 PM, Eric Sunshine wrote: > > > On Tue, Jun 19, 2018 at 2:06 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > > > Torsten Bögershausen <tboegi@xxxxxx> writes: > > > > > t5562 fails here under MacOS: > > > > > "gzip -k" is not portable. > > > Very odd. Stock /usr/bin/gzip on my MacOS 10.12.6 _does_ recognize -k, > > > and the test does pass. > > > > This is the test box running Mac OS X 10.6 speaking. > > The -c seems to need even -f. > > But this doesn't work either: > > > > gzip 1.3.12 > > Copyright (C) 2007 Free Software Foundation, Inc. > > Copyright (C) 1993 Jean-loup Gailly. > > This is free software. You may redistribute copies of it under the terms of > > the GNU General Public License <http://www.gnu.org/licenses/gpl.html>. > > There is NO WARRANTY, to the extent permitted by law. > > Ah, that's it. "-k" came about in gzip v1.6. That's 5 years old, but > obviously some people are still running it. > > "-c" goes back quite a while and should be safe, I think. > > > expecting success: > > gzip -f -c fetch_body >fetch_body.gz && > > test_copy_bytes 10 <fetch_body.gz >fetch_body.gz.trunc && > > gzip -f -c push_body >push_body,gz && > > test_copy_bytes 10 <push_body.gz >push_body.gz.trunc > > > > ./test-lib.sh: line 632: push_body.gz: No such file or directory > > Typo in the ">" redirect (comma instead of period)? > > -Peff Good eyes, thanks. The "-f -c" combo works: - gzip -k fetch_body && + gzip -f -c fetch_body >fetch_body.gz && test_copy_bytes 10 <fetch_body.gz >fetch_body.gz.trunc && - gzip -k push_body && + gzip -f -c push_body >push_body.gz &&
