Re: [PATCH 2/7] grep.c: expose {,inverted} match column in match_line()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Taylor Blau <me@xxxxxxxxxxxx> writes:

>  	case GREP_NODE_NOT:
> -		h = !match_expr_eval(x->u.unary, bol, eol, ctx, 0);
> +		/*
> +		 * Upon visiting a GREP_NODE_NOT, imatch and match become
> +		 * swapped.
> +		 */
> +		h = !match_expr_eval(x->u.unary, bol, eol, ctx, icol, col, 0);

A minor nit, but the comment talks about something that are
different from the variable names; perhaps you called col/icol with
different names in an earlier incarnation of this patch?




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux