Hi Christian, Le 18/06/2018 à 18:26, Christian Couder a écrit : > Hi Alban, > > On Mon, Jun 18, 2018 at 3:18 PM, Alban Gruin <alban.gruin@xxxxxxxxx> wrote: >> This adds a new function, run_command_silent_if_successful(), > > He re the function is called run_command_silent_if_successful()... > >> to >> redirect the stdout and stderr of a command to a strbuf, and then to run >> that command. This strbuf is printed only if the command fails. It is >> functionnaly similar to output() from git-rebase.sh. >> >> run_git_commit() is then refactored to use of >> run_command_silent_if_successful(). > > ...here also... > > [...] > >> +static int run_command_silent_on_success(struct child_process *cmd) > > ...but here it is called run_command_silent_on_success(). > > Thanks, > Christian. > Oops, my bad. I will fix this in a reroll. Cheers, Alban
