On Sat, Jun 16, 2018 at 10:57 PM Christian Couder <christian.couder@xxxxxxxxx> wrote: > On Fri, Jun 15, 2018 at 12:47 AM, Mahmoud Al-Qudsi <mqudsi@xxxxxxxxxxxx> wrote: > > ~> make NO_ICONV=1 > > # ommitted > > LINK git-credential-store > > /usr/bin/ld: cannot find -liconv > I think 597c9cc540 (Flatten tools/ directory to make build procedure > simpler., 2005-09-07) which introduces NEEDS_LIBICONV is even older > than the commit that introduced NO_ICONV (see above), so you might > want to play with NEEDS_LIBICONV too and see if it works better for > you. > > I CC'ed the people involved in related commits. Maybe they can give > you a better answer. It might also help if you could tell us on which > OS/Platform and perhaps for which purpose you want to compile Git. For completeness, for those reading this thread, a patch fixing this issue has already been sent[1] to the list. [1]: https://public-inbox.org/git/20180615022503.34111-1-sunshine@xxxxxxxxxxxxxx/
