On Fri, Jun 15, 2018 at 4:27 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > * es/make-no-iconv (2018-06-15) 1 commit > - Makefile: make NO_ICONV really mean "no iconv" > > "make NO_ICONV=NoThanks" did not override NEEDS_LIBICONV Nit: The double-negative is a bit confusing. s/NoThanks/YesPlease/ would be easier to grok and would be more idiomatic (taking config.mak.uname into account). > (i.e. linkage of -lintl, -liconv, etc. that are platform-specific > tweaks), which has been corrected.
