Derrick Stolee <stolee@xxxxxxxxx> writes: >> ewah_clear() can become file-scope static, and >> rlwit_discharge_empty() can be eliminated. I do not know if either >> is worth doing, though. > > With Peff's patches, this is true. When I applied your diff to my > patch alone we could not do that. Yeah, as I organized the patches on two topics in this order: jk/ewah-bounds-check (build on 'maint') Peff's 1/3 Peff's 4/3 ds/ewah-cleanup (build on top of the above) 7 patches in this series Peff's 2/3 Peff's 3/3 at the end, these two changes become possible. Again, I am not sure if these are worth doing, so I'll leave it out of these two series, at least for now. This is a tangent, but I too felt that roaring paper quite a pleasant read ;-)