Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes:
> -static struct prio_queue rev_list = { compare_commits_by_commit_date };
> -static int non_common_revs, multi_ack, use_sideband;
> +struct data {
> + struct prio_queue rev_list;
> + int non_common_revs;
> +};
> +
> +static int multi_ack, use_sideband;
Aside from Brandon's comments, I think passing these throughout the
callchain instead of having them as static-globals is a step in the
right direction. Could you, however, give the structure a bit more
descriptive name, than simply "data"? Anything the computer works
on is "data", and there must be something more specific than that
about this particular struct ;-)
