On Tue, Jun 12, 2018 at 09:29:13AM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > To be honest, I could easily see an argument that I _should_ be setting > > GIT_SSH_VARIANT to explain what my wrapper is expecting, even though it > > happened to work before. > > The way I read that message is that the patch proposed in > > https://public-inbox.org/git/20180103050730.GA87855@xxxxxxxxxxxxxxxxxxxxxxxxx > > is "lesser of two evils" in that it is still evil because somebody > still has to be asked to explicitly set "variant" anyway but the > changing what 'simple' means in the middle would mean those who did > not have to set it now have to. So, you should be setting it, even > if we adopt the patch, right? ;-) No, my wrapper _isn't_ simple. It passes most options to openssh, but just doesn't understand the "-G" probing. So if the default was openssh-like instead of "simple", then that would work fine without me setting anything, just like it did before. Which I thought was where the discussion ended up, but perhaps I'm misunderstanding. > My impression is that regression "fix" does not exist---rather, it > was a proposal (and it may make a better tradeoff than the status > quo) to help users of older OpenSSH by inconveniencing users of > different implementations that do -4/6/p differently from OpenSSH. Right. That fixes the regression for openssh users, at the cost of not help people on other implementations automatically. But those people have to set the flag anyway, since the current behavior is "whoops, we don't know how to support you, set the flag". To be clear, I've already fixed my setup, and it wasn't that big a deal. And I doubt all that many people would be affected either way. My use case here was literally instrumenting the ssh calls of the git client as part of a regression test suite. How many git test suites could there possibly be? :) So I'm OK if we just leave it as-is. It's mostly that I dug into the thread and was left with the impression that it was an unfinished leftover that we meant to do. > In any case, from where I sit, I am still waiting for this offer > by Jonathan > > > It's good you caught this flaw in the detection. Would something like > > the following make sense? If so, I can resend with a commit message > > and tests tomorrow or the day after. > > to be followed up ;-) Yes, that was the part that left the impression. :) -Peff
