On Thu, Jun 14, 2018 at 1:08 AM Stefan Beller <sbeller@xxxxxxxxxx> wrote: > > * removed mentions of cooci patches > * added forward declaration of commit buffer slabs. > * dropped 3 patches that add the repository to lookup_unkonwn_object, > parse_commit and parse_commit_gently, but were not converting those > functions. We'll convert these in the next series, as this series is > growing big already. > * This series can be found as branch 'object-store-lookup-commit' on github, > it applies on top of nd/commit-util-to-slab merged with sb/object-store-grafts > > v1, https://public-inbox.org/git/20180530004810.30076-1-sbeller@xxxxxxxxxx/ > > This applies on the merge of nd/commit-util-to-slab and sb/object-store-grafts, > and is available at http://github.com/stefanbeller/ as branch object-store-lookup-commit I only looked at whole-series diff, not individual patches (sorry). Besides the one comment I made elsewhere, it looks good. You don't even need to reroll this series to address that one. A follow up patch whenever you feel like it is fine, or I'll get to it eventually (after the_index is gone, I plan to kill the_repository outside builtin/ too, for the same reason). -- Duy
