Hi Alban On 13/06/18 16:22, Alban Gruin wrote: > This patch rewrites the edit-todo functionality from shell to C. This is > part of the effort to rewrite interactive rebase in C. > > Changes since v1: > > - Add a new function to launch the sequence editor, as advised by > Phillip Wood[0] That's great, I think these look fine now Best Wishes Phillip > [0] https://public-inbox.org/git/3bfd3470-4482-fe6a-2cd9-08311a0bbaac@xxxxxxxxxxxx/ > > Alban Gruin (2): > editor: add a function to launch the sequence editor > rebase--interactive: rewrite the edit-todo functionality in C > > builtin/rebase--helper.c | 13 ++++++++----- > cache.h | 1 + > editor.c | 27 +++++++++++++++++++++++++-- > git-rebase--interactive.sh | 11 +---------- > sequencer.c | 31 +++++++++++++++++++++++++++++++ > sequencer.h | 1 + > strbuf.h | 2 ++ > 7 files changed, 69 insertions(+), 17 deletions(-) >