On Wed, Jun 6, 2018 at 12:38 PM Duy Nguyen <pclouds@xxxxxxxxx> wrote: > > On Wed, May 30, 2018 at 2:47 AM, Stefan Beller <sbeller@xxxxxxxxxx> wrote: > > diff --git a/object.c b/object.c > > index 4de4fa58d59..def3c71cac2 100644 > > --- a/object.c > > +++ b/object.c > > @@ -177,7 +177,7 @@ void *object_as_type(struct object *obj, enum object_type type, int quiet) > > } > > } > > > > -struct object *lookup_unknown_object(const unsigned char *sha1) > > +struct object *lookup_unknown_object_the_repository(const unsigned char *sha1) > > I'm looking at your branch and this function (with the _the_repository > suffix) is still there. Did you forget to send a patch to convert this > function? This and parse_commit and parse_commit_gently have not been converted. I stopped with this series as soon as I hit the commit-graph code, which needs to be updated, too. I'll start redoing this series soon and will fix those conversions.