On Tue, Jun 12, 2018 at 5:25 PM, Stefan Beller <sbeller@xxxxxxxxxx> wrote: > When running t7400 in a shell you observe more output than expected: > ... > ok 10 - submodule add > [master (root-commit) d79ce16] one > Author: A U Thor <author@xxxxxxxxxxx> > 1 file changed, 1 insertion(+) > create mode 100644 one.t > ok 11 - redirected submodule add does not show progress > ... > Fix the output by encapsulating the setup code in test_expect_success > > Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> > --- > diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh > @@ -126,8 +126,10 @@ test_expect_success 'submodule add' ' > -test_create_repo parent && > -test_commit -C parent one > +test_expect_success 'setup parent and one repository for further tests' ' Nit: "for further tests" is implied for actions performed by a "setup" function, so a bit redundant to say so. > + test_create_repo parent && > + test_commit -C parent one > +'
