On Tue, Jun 12, 2018 at 11:08 AM Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
>
> Hi,
>
> Stefan Beller wrote:
>
> > Any caller except of git_gpg_config() except the one in send_pack_config()
> > handles the return value of git_gpg_config(). Also handle the return value
> > there.
> >
> > Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx>
> > ---
> > builtin/send-pack.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> The other callers do
except builtin/log, which I followed. :/
>
> int status;
>
> if (!strcmp(k, "key.i.handle")) {
> ...
> return ...;
> }
> return git_gpg_config(k, v, NULL);
This conflicts with Masayas patch, that has a return of the
standard options.
>
> or
>
> int status;
>
> if (!strcmp(k, "key.i.handle")) {
> ...
> return ...;
> }
>
> status = git_gpg_config(k, v, NULL);
> if (status)
> return status;
> ...
This looks like a good idea.
Will send a follow up patch.
