On Sat, Jun 9, 2018 at 4:04 AM Duy Nguyen <pclouds@xxxxxxxxx> wrote: > > On Tue, Jun 05, 2018 at 05:31:41PM +0200, Duy Nguyen wrote: > > I do not know how to reproduce this (and didn't bother to look deeply > > into it after I found it was not a trivial fix) but one of my "git > > fetch" showed > > > > warning: Submodule in commit be2db96a6c506464525f588da59cade0cedddb5e > > at path: '(null)' collides with a submodule named the same. Skipping > > it. > > The problem is default_name_or_path() can return NULL when a submodule > is not populated. The fix could simply be printing path instead of > name (because we are talking about path in the commit message), like > below. > > But I don't really understand c68f837576 (implement fetching of moved > submodules - 2017-10-16), the commit that made this change, and not > sure if we should be reporting name here or path. Heiko? That change is quite interesting as I did not understand it at first sight as well. See https://public-inbox.org/git/20171016135827.GC12756@xxxxxxxxxxxxxxx/ and the follow ups, specifically https://public-inbox.org/git/20171019181109.27792-2-sbeller@xxxxxxxxxx/ that tries to clean up the code, but was ultimately dropped.
