Hi Elijah, Le 12/06/2018 à 17:46, Elijah Newren a écrit : > Hi Alban, > > On Mon, Jun 11, 2018 at 6:57 AM, Alban Gruin <alban.gruin@xxxxxxxxx> wrote: >> This rewrites the edit-todo functionality from shell to C. >> >> To achieve that, a new command mode, `edit-todo`, is added, and the >> `write-edit-todo` flag is removed, as the shell script does not need to >> write the edit todo help message to the todo list anymore. >> >> The shell version is then stripped in favour of a call to the helper. > > I looked over the patch and didn't see any problems (though I haven't > worked with rebase--helper before, or the code for todo list editing), > but when I went to apply the patch it failed telling me: > > Applying: rebase--interactive: rewrite the edit-todo functionality in C > error: sha1 information is lacking or useless (builtin/rebase--helper.c). > error: could not build fake ancestor > Patch failed at 0001 rebase--interactive: rewrite the edit-todo > functionality in C > Use 'git am --show-current-patch' to see the failed patch > > I tried each of master, next, and pu (as of today) to see if it might > apply there. On which commit is this patch based? (Do you have other > local commits that this was based on top of?) > > > Elijah > It can be applied on top of pu with my patch that rewrites append_todo_help() in C (https://public-inbox.org/git/20180607103012.22981-1-alban.gruin@xxxxxxxxx/) Cheers, Alban
