On Sat, Jun 09, 2018 at 11:46:13AM +0200, SZEDER Gábor wrote: > I add few more lines of context here: > > tree=$( > { > printf "100644 blob $content\t$tricky\n" && > > > printf "120000 blob $target\t.gitmodules\n" > > } | git mktree > > ) && > > - commit=$(git commit-tree $tree) && > > This was the only case where that $tree variable was used, so perhaps > that can go away as well, in the name of even more simplicity? Yep, that is simpler. Here's a v3 just dropping those $tree variables, and adjusting the commit message as appropriate. [1/2]: t7415: don't bother creating commit for symlink test [2/2]: fsck: avoid looking at NULL blob->object fsck.c | 3 ++- t/t7415-submodule-names.sh | 29 ++++++++++++++++++++++------- 2 files changed, 24 insertions(+), 8 deletions(-) -Peff