In ac53fe8601 ("sha1_name: convert uses of 40 to GIT_SHA1_HEXSZ", 2017-07-13) the code this is validating user input for in find_unique_abbrev_r() was converted to GIT_SHA1_HEXSZ, but the corresponding validation codepath wasn't change. Let's do that. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> --- parse-options-cb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/parse-options-cb.c b/parse-options-cb.c index 0f9f311a7a..298b5735c8 100644 --- a/parse-options-cb.c +++ b/parse-options-cb.c @@ -21,8 +21,8 @@ int parse_opt_abbrev_cb(const struct option *opt, const char *arg, int unset) return opterror(opt, "expects a numerical value", 0); if (v && v < MINIMUM_ABBREV) v = MINIMUM_ABBREV; - else if (v > 40) - v = 40; + else if (v > GIT_SHA1_HEXSZ) + v = GIT_SHA1_HEXSZ; } *(int *)(opt->value) = v; return 0; -- 2.17.0.290.gded63e768a