On Thu, Jun 07, 2018 at 12:57:04AM +0000, brian m. carlson wrote: > > > Unless I'm wrong, we don't use the "local" keyword ? > > > > We've got a test balloon out; see 01d3a526ad (t0000: check whether the > > shell supports the "local" keyword, 2017-10-26). I think it's reasonable > > to consider starting its use. > > I used it because it's already in use earlier in the file in some of the > mingw_* functions. Perhaps we happen to know that our mingw systems > will always have a suitable /bin/sh, but I suppose some less capable > shells would still have choked on it by now. We do know in that case; it's always bash under mingw. That said... > I can remove it if necessary, but it didn't seem necessary. I feel OK about starting to use it, with the knowledge that we may get a late-comer who hasn't even tested v2.16.0 yet and says "no, wait! My shell doesn't support local!". And then we'd have to deal with it then. But I suspect that won't happen, or it will turn out that the shell in question is unusable for some other reason anyway. -Peff
