On Mon, Jun 04, 2018 at 01:31:58PM +0900, Junio C Hamano wrote:
> Max Kirillov <max@xxxxxxxxxx> writes:
>> + size_t n = xread(0, buf, chunk_length);
>> + if (n < 0)
>> + die_errno("Reading request failed");
>
> n that is of type size_t is unsigned and cannot be negative here.
Thanks, fixing it
Do you think sanity check for n <= chunk_length (the code
will go mad in this case) is needed? As far as I can see n
returns straight from system's read()
