Re: [PATCH v4] json_writer: new routines to create data in JSON format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 02, 2018 at 06:41:06AM +0200, Duy Nguyen wrote:

> On Mon, Mar 26, 2018 at 4:31 PM,  <git@xxxxxxxxxxxxxxxxx> wrote:
> > +static inline void assert_in_array(const struct json_writer *jw)
> > +{
> > +       if (!jw->open_stack.len)
> > +               die("json-writer: array: missing jw_array_begin()");
> 
> When you reroll, please consider marking all these string for
> translation with _(), unless these are for machine consumption.

Actually, these are all basically asserts, I think. So ideally they'd be
BUG()s and not translated.

-Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux