On Mon, Jun 11, 2007 at 05:01:23PM +0200, Jonas Fonseca wrote: > Thanks for looking into this and making these patches. :) No problem. I had run it across it before and it was on my "look into this" list...thank you for providing a test case. :) > I think you could even get rid of has_ignored with something like this. Nope, I had originally wanted to do that, but the dir_struct.ignored list contains _all_ ignored items, not just those that were originally in the pathspec. The prune_ignored call sets uninteresting ones to NULL. That function could compact the list and re-set ignored_nr, but it doesn't currently do so. An even more elegant solution would be for read_directory to mark whether an ignored file comes from a pathspec, or was found through recursion. That would be more efficient, and it would remove the prune_ignored thing, which is IMHO a little hack-ish. I don't have time to work on it now, but I might look at it more tonight or tomorrow (but please, if you are interested, take a crack at it). -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
