On 31/05/18 20:25, Alban Gruin wrote:
Hi Phillip,
Le 31/05/2018 à 19:48, Phillip Wood a écrit :
Hi Alban, it's great to see you working on this
On 31/05/18 12:01, Alban Gruin wrote:
This series rewrites append_todo_help() from shell to C. This is part
of the effort to rewrite interactive rebase in C.
The first commit rewrites append_todo_help() in C (the C version
covers a bit more than the old shell version), adds some parameters to
rebase--helper, etc.
I've had a read of the first patch and I think it looks fine, my only
comment would be that the help for '--edit-todo' is a bit misleading at
the moment as currently it's just a flag to tell rebase-helper that the
todo list is being edited rather than actually implementing the
functionality to edit the list
Right, what do you think about something like “appends the edit-todo
message to the todo list”?
Yes that sounds good, though if you're about to implement editing the
todo list with --edit-todo I wouldn't worry too much
Best Wishes
Phillip
(but hopefully that will follow in the
future).
This is the next step :)
Cheers,
Alban
