On Thu, May 31, 2018 at 12:33 PM, Alban Gruin <alban.gruin@xxxxxxxxx> wrote: > Hi Stefan, > > Le 31/05/2018 à 20:44, Stefan Beller a écrit : >> On Thu, May 31, 2018 at 10:48 AM, Phillip Wood >> <phillip.wood@xxxxxxxxxxxx> wrote: >>> Hi Alban, it's great to see you working on this >>> >>> On 31/05/18 12:01, Alban Gruin wrote: >>>> This series rewrites append_todo_help() from shell to C. This is part >>>> of the effort to rewrite interactive rebase in C. >>>> >>>> The first commit rewrites append_todo_help() in C (the C version >>>> covers a bit more than the old shell version), adds some parameters to >>>> rebase--helper, etc. >>> >>> I've had a read of the first patch and I think it looks fine, my only >>> comment would be that the help for '--edit-todo' is a bit misleading at >>> the moment as currently it's just a flag to tell rebase-helper that the >>> todo list is being edited rather than actually implementing the >>> functionality to edit the list (but hopefully that will follow in the >>> future). >> >> Would you have better suggestions for the name of the flag? >> Of the top of my head: >> --write-edit-todo >> --hint-todo-edit >> --include-todo-edit-hint >> not sure I like these names, though they seem to reflect the >> nature of that flag a little bit better. >> > > As my next patch series will probably be about rewriting edit-todo in C, > do you really think I should rename the flag? If you reroll, you could think of doing that. If you have the next series prepared already that build on top, it may not be worth it. >> If you feel strongly, I'd rather see Alban drop this second patch and >> move on instead of waiting for our argument to settle. ( I do not feel >> strongly about it, but put it out as a suggestion as that seemed like >> it would lead to a better end state for the project). >> > > Okay, so I drop this patch and reroll the other? Sure, but maybe give Philip some time to react?
