'item->dst' has not been assigned if '!rhs' is true. As the caller is allowed to pass in uninitialized
memory (we don't assume 'item' was zeroed out before calling), this fixes an access to
uninitialized memory.
Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx>
---
applies on bw/refspec-api
refspec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/refspec.c b/refspec.c
index c59a4ccf1e5..ea169dec0d3 100644
--- a/refspec.c
+++ b/refspec.c
@@ -108,7 +108,7 @@ static int parse_refspec(struct refspec_item *item, const char *refspec, int fet
* - empty is not allowed.
* - otherwise it must be a valid looking ref.
*/
- if (!item->dst) {
+ if (!rhs) {
if (check_refname_format(item->src, flags))
return 0;
} else if (!*item->dst) {
--
2.17.0.582.gccdcbd54c44.dirty
