On 23 May 2018 at 17:41, Mazo, Andrey <amazo@xxxxxxxxxxxxxx> wrote: >> The last one (i.e. "even if it is verbose, if fileSize is not >> reported, do not write the verbose output") does not look like it is >> limited to the unshelve feature, so it might, even though it is a >> one-liner, deserve to be a separate preparatory patch if you want. >> But I do not feel strongly about either way. > > This was actually discussed in a separate thread [1] some time ago with patches proposed by Thandesha and me. > I haven't yet got time to cook a final patch, which addresses both Thandesha's and mine use-cases though, > so this wasn't submitted to Junio yet. > In the meantime, I guess, one of the patches [2] from that thread can be taken as is. > > [1] "[BUG] git p4 clone fails when p4 sizes does not return 'fileSize' key" > https://public-inbox.org/git/CAJJpmi-pLb4Qcka5aLKXA8B1VOZFFF+OAQ0fgUq9YviobRpYGg@xxxxxxxxxxxxxx/t/#mee2ec50a40242089741f808f06214a44278055b3 > [2] "[PATCH 1/1] git-p4: fix `sync --verbose` traceback due to 'fileSize'" > https://public-inbox.org/git/2e2b2add4e4fffa4228b8ab9f6cd47fa9bf25207.1523981210.git.amazo@xxxxxxxxxxxxxx/ Should I re-roll my patch without this change then? Luke
