On 22/05/18 00:59, Junio C Hamano wrote: > Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> writes: > >> I strongly suspect that I haven't followed the discussion on >> the list closely enough, but your 'ma/unpack-trees-free-msgs' >> branch in 'pu', seems to define string_list_appendf() but then >> never call it. This is despite commit 40ebd6c7b0 ("string-list: >> provide `string_list_appendf()`", 2018-05-20) claiming that: >> 'The next commit will add a user'. ;-) >> >> Have I missed something? > > Yes, I pushed out a tentative "how about doing it this way" update > that goes alongside his version, making some solutions (including > the function you found) he had obsoleted, yet without removing > them. That is what you saw on 'pu'. > > There is a reroll by Martin that ties all the loose ends. Ah, OK, sorry for the noise. Thanks! ATB, Ramsay Jones