On Mon, May 21, 2018 at 12:41 PM, Jeff King <peff@xxxxxxxx> wrote: > On Mon, May 21, 2018 at 11:11:51AM -0700, Stefan Beller wrote: > >> Hi Jeff, >> >> On Fri, May 18, 2018 at 6:56 PM, Jeff King <peff@xxxxxxxx> wrote: >> >> > @@ -2421,4 +2426,5 @@ void release_http_object_request(struct http_object_request *freq) >> .. >> > + strbuf_release(&freq->tmpfile); >> >> Do we need an equivalent in release_http_pack_request as well? > > Yes, but isn't there one? > > From the original patch: > > --- a/http.c > +++ b/http.c > @@ -2082,6 +2082,7 @@ void release_http_pack_request(struct http_pack_request *preq) > preq->packfile = NULL; > } > preq->slot = NULL; > + strbuf_release(&preq->tmpfile); > free(preq->url); > free(preq); > } which is at the very top, but I was not looking this far up, but looked for functions order that my editor had. Clearly I have to practice code reviews, still. Sorry for the noise. Stefan
