On Sat, May 19, 2018 at 10:27:46AM +0200, René Scharfe wrote: > Am 19.05.2018 um 03:57 schrieb Jeff King: > > These formatted integers should always fit into their > > 64-byte buffers. Let's use xsnprintf() to add an assertion > > that this is the case, which makes auditing for other > > unchecked snprintfs() easier. > > How about this instead? > > -- >8 -- > Subject: [PATCH] fsmonitor: use internal argv_array of struct child_process Yeah, I agree that is much nicer (I was so focused on the snprintfs I didn't bother to look at the context for a better solution). Thanks, getting a review in the form of a complete patch is my favorite kind of review. :) > Inspired-by: Jeff King <peff@xxxxxxxx> Heh. -Peff
