On 14 May 2018 at 05:03, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Sun, May 13, 2018 at 5:58 AM, Martin Ågren <martin.agren@xxxxxxxxx> wrote: >> >> How about the following two patches as patches 2/3 and 3/3? I would also >> need to mention in the commit message of this patch (1/3) that the >> function will soon learn to clean up more members. >> > > Yep, making this a multi-part patch series and updating the commit > message of the patch which introduces config_store_data_clear(), as > you suggest, makes sense. The patch series could be organized > differently -- such as first moving freeing of 'value_regex' into new > config_store_data_clear(), then freeing additional fields in later > patches -- but I don't think it matters much in practice, so the > current organization is likely good enough. I tried such a re-ordering but wasn't entirely happy about the result (maybe I didn't try hard enough), so here are these patches again, as a proper series and with improved commit messages. Martin Martin Ågren (3): config: free resources of `struct config_store_data` config: let `config_store_data_clear()` handle `value_regex` config: let `config_store_data_clear()` handle `key` config.c | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) -- 2.17.0.840.g5d83f92caf
