On Wed, May 16, 2018 at 03:21:07PM -0700, Stefan Beller wrote: > > If you have time, yes translate them all. I don't see how any of these > > strings are meant for script. If not, just _() the new string you > > added is fine. > > > With a majority of call sites dying like this though, I wonder if we > > should just add repo_read_index_or_die() with die() inside. Then the > > next person won't likely accidentally forget _() > > So this comment tricked me into coming up with a patch series. :) Yay! (And sorry, Junio) > > Each patch is themed, I tried to make each commit special w.r.t. reviewers > attention. > > We'd start out with a resend of the origin patch, which is boring. > > Then we'll move all similar cases into one function (no-op for > introducing the repo_read_index_or_die function as all callers will have the > same error message and the same localisation). > > Any following patch will be more controversial then the previous patches, > I would expect, as we introduce more and more change. > > The last patch is just an attempt to finish the series gracefully, > and may contain errors (sometimes we do not want to die() in case of > corrupt index). > > Is this series roughly what you had in mind? This is better than what I had in mind, in fact. -- Duy
