On Mon, May 14, 2018 at 8:45 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > >> It's done so that commit->util can be removed. See more explanation in >> the commit that removes commit->util. >> >> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> >> --- >> builtin/show-branch.c | 39 +++++++++++++++++++++++++++------------ >> 1 file changed, 27 insertions(+), 12 deletions(-) > > Looks obviously correct. > > Another place we could use commit-slab in this program, which I > think is a more interesting application, is to use it to store a > bitmask with runtime-computed width to replace those object->flags > bits, which will allow us to lift the MAX_REVS limitation. Interesting. I have a feeling paint_down() from shallow.c might be reusable. Anyway I don't have enough interest in this command to actually fix this so I'll just make a TODO note in case people need something to do and grep for them in the code. -- Duy
