On Thu, May 17, 2018 at 2:48 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Martin Ågren <martin.agren@xxxxxxxxx> writes: > >> After we initialize the various fields in `opts` but before we actually >> use them, we might return early. Move the initialization further down, >> to immediately before we use `opts`. >> >> This limits the scope of `opts` and will help a later commit fix a >> memory leak without having to worry about those early returns. >> >> This patch is best viewed using something like this (note the tab!): >> --color-moved --anchored=" trees[nr_trees] = parse_tree_indirect" > > This side remark is interesting because it totally depends on how > you look at it. I think "initialize opts late" and "attempt to > parse the trees first and fail early" are the sides of the same > coin, and the diff shown without the anchor matches the latter, > which is also perfectly acceptable interpretation of what this patch > does. > Yes. I like that we have tools available to show diffs in different hopefully meaningful ways. I happen to like when the diff matches my mental map of the change after reading the commit message, so having the author indicate how best to view it is useful, but definitely cool to see that we can get different interpretations. Thanks, Jake
