On Wed, May 16, 2018 at 2:42 PM, Brandon Williams <bmwill@xxxxxxxxxx> wrote: > On 05/16, Ramsay Jones wrote: >> >> Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> >> --- >> >> Hi Brandon, >> >> If you need to re-roll your 'bw/refspec-api' branch, could you please >> squash this, or the equivalent change before the 'struct refname' to >> 'struct refname_item' name change, into the relevant patch. (which >> would be patch #1, commit 8999381ed). >> >> This patch was built on top of 'pu', but as I said above, patch #1 >> is where the original 'extern' keyword was dropped. (see first hunk >> of the diff to 'remote.h'). > > Of course I'll do that, I'm planning on sending out a v2 by the end of > the day and I'll incorporate that. > > Though now I'm confused, I thought we were going towards eliminating > using the extern keyword? ...of course I guess it means something > _slightly_ different when using with a variable vs a function :) We're only eliminating it when it is redundant. :-) For variables this is not redundant as we need it to tell apart the declaration and definition of it, so we have to keep it.
