On 7 May 2018 at 12:05, Martin Ågren <martin.agren@xxxxxxxxx> wrote: > On 7 May 2018 at 09:39, Michael Haggerty <mhagger@xxxxxxxxxxxx> wrote: >> Thanks for the patch. This looks good to me. But it it seems that the >> test coverage related to pseudorefs is still not great. Ideally, all of >> the following combinations should be tested: > > Thank you for your comments. I was not able to find much > pseudoref-testing. I think what I should do is a patch 1/2 adding the > tests you outlined (some will be expected failures), then turn this > patch into a patch 2/2. Well, it turned into three patches. One to move away from "sha1" in some error messages before spreading them to the test suite, then one to add the tests, then one for the actual fix. Martin Martin Ågren (3): refs.c: refer to "object ID", not "sha1", in error messages t1400: add tests around adding/deleting pseudorefs refs: handle zero oid for pseudorefs t/t1400-update-ref.sh | 60 +++++++++++++++++++++++++++++++++++++++++++ refs.c | 22 ++++++++++++---- 2 files changed, 77 insertions(+), 5 deletions(-) -- 2.17.0
