Hi, On Sat, 9 Jun 2007, Johan Herland wrote: > Also update selftests to reflect new error messages. Had you split the patch conceptually, the changes to the tests would have been included where appropriate. I consider a patch _breaking_ a test case, with a follow up patch to the test case, a _bug_. And I consider a change in error messages not good, _unless_ the changes have a real value in practice. Which I maintain they do not, in this patch-series' case. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html