Hi, On Sat, 9 Jun 2007, Johan Herland wrote: > I'm probably splitting this up into too small pieces, since I keep > getting comments that fail to see the overall picture of what I'm trying > to do, [...] Maybe I said that your patch was too large. But then, I said something much more important: hard-to-review. These small patches, split in a manner making it even more difficult to understand what you want to accomplish, do not help. Yes, you should make small patches. Even small patch series. But in such a fashion that a reviewer can see that it is a good patch[*1*]. Just lean back, look at your patches, and ask yourself how you would have reacted if you had reviewed them. Ciao, Dscho *1* A good patch follows the immortal words of Saint Exupery: A designer knows he has achieved perfection not when there is nothing left to add, but when there is nothing left to take away. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
