Hi everyone, Should `contrib/` area patches go here, too? Contributed Software page https://git.kernel.org/pub/scm/git/git.git/tree/contrib/README says to forward them to "jc" (I'm guessing that's Junio), but I think they're getting missed. Though the component author approves (acknowledgement below), am I missing anything for submission? Thanks. > git-credential-netrc was hardcoded to call 'gpg' for decryption. > This is a problem on distributions like Debian that call modern > GnuPG something else, like 'gpg2'. This proposed update reuses > git's gpg.program configuration to customize GnuPG's name. It > introduces the -g|--gpg option on the git-credential-netrc > command to allow alternatively setting it in git's > credential.helper configuration. Since testing a git > configuration involves a temporary repository as provided by > git's main testing framework, a patch updating tests to reuse > the main framework is included, too. ------- Forwarded message Delivered-To: luis.marsano@xxxxxxxxx Received: by 10.103.152.29 with SMTP id a29csp214132vse; Fri, 20 Apr 2018 16:18:34 -0700 (PDT) Return-Path: <ted@xxxxxxxxxxxx> In-Reply-To: <1524160133-8877-1-git-send-email-luis.marsano@xxxxxxxxx> References: <1524160133-8877-1-git-send-email-luis.marsano@xxxxxxxxx> From: Ted Zlatanov <tzz@xxxxxxxxxxxx> Date: Fri, 20 Apr 2018 19:18:32 -0400 Message-ID: <CAMdP0d=sNtgwDnfZz88_cmAt6VYMGOozOC5q4o32R+yw+UcrAQ@xxxxxxxxxxxxxx> Subject: Re: [RFC PATCH 0/2] Configurable GnuPG command for git-credential-netrc To: Luis Marsano <luis.marsano@xxxxxxxxx> Status: OR That looks terrific, Luis. It's a good change so I'd just go ahead and propose those patches. I don't see anything incorrect and tests are always good. Ted On Thu, Apr 19, 2018 at 1:48 PM, Luis Marsano luis.marsano@xxxxxxxxx wrote: > Hello Ted Zlatanov, > Thank you for git-credential-netrc. Will you please look over > these patches and decide if they need more work? They're also > available as the netrc-option branch at > https://github.com/lmmarsano/git This is a first contribution > for me, and I welcome input, suggestions, criticisms, > corrections. Thanks. > git-credential-netrc was hardcoded to call 'gpg' for decryption. > This is a problem on distributions like Debian that call modern > GnuPG something else, like 'gpg2'. This proposed update reuses > git's gpg.program configuration to customize GnuPG's name. It > introduces the -g|--gpg option on the git-credential-netrc > command to allow alternatively setting it in git's > credential.helper configuration. Since testing a git > configuration involves a temporary repository as provided by > git's main testing framework, a patch updating tests to reuse > the main framework is included, too. > Luis Marsano (2): > git-credential-netrc: adapt to test framework for git > git-credential-netrc: accept gpg option > contrib/credential/netrc/Makefile | 4 +- > contrib/credential/netrc/git-credential-netrc | 69 +++++++++++------ > contrib/credential/netrc/t-git-credential-netrc.sh | 31 ++++++++ > contrib/credential/netrc/test.command-option-gpg | 2 + > contrib/credential/netrc/test.git-config-gpg | 2 + > contrib/credential/netrc/test.netrc.gpg | 0 > contrib/credential/netrc/test.pl | 86 > +++++++++++++++------- > 7 files changed, 142 insertions(+), 52 deletions(-) > create mode 100755 contrib/credential/netrc/t-git-credential-netrc.sh > create mode 100755 contrib/credential/netrc/test.command-option-gpg > create mode 100755 contrib/credential/netrc/test.git-config-gpg > create mode 100644 contrib/credential/netrc/test.netrc.gpg > -- > 2.7.4 ------- End of Forwarded message Luis Marsano (2): git-credential-netrc: adapt to test framework for git git-credential-netrc: accept gpg option contrib/credential/netrc/Makefile | 4 +- contrib/credential/netrc/git-credential-netrc | 69 ++++++++++----- .../netrc/t-git-credential-netrc.sh | 31 +++++++ .../credential/netrc/test.command-option-gpg | 2 + contrib/credential/netrc/test.git-config-gpg | 2 + contrib/credential/netrc/test.netrc.gpg | 0 contrib/credential/netrc/test.pl | 86 +++++++++++++------ 7 files changed, 142 insertions(+), 52 deletions(-) create mode 100755 contrib/credential/netrc/t-git-credential-netrc.sh create mode 100755 contrib/credential/netrc/test.command-option-gpg create mode 100755 contrib/credential/netrc/test.git-config-gpg create mode 100644 contrib/credential/netrc/test.netrc.gpg -- 2.17.0
