On Tue, May 8, 2018 at 10:53 PM, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > On Mon, 7 May 2018, SZEDER Gábor wrote: > >> The test script 't6050-replace.sh' starts off with redirecting the whole >> test script's stdin from /dev/null. This redirection has been there >> since the test script was introduced in a3e8267225 (replace_object: add >> a test case, 2009-01-23), but the commit message doesn't explain why it >> was deemed necessary. AFAICT, it has never been necessary, and t6050 >> runs just fine and succeeds even without it, not only the current >> version but past versions as well. >> >> Besides being unnecessary, this redirection is also harmful, as it >> prevents the test helper functions 'test_pause' and 'debug' from working >> properly in t6050, because we can't enter any commands to the shell and >> the debugger, respectively. > > The redirection might have been necessary before 781f76b1582 (test-lib: > redirect stdin of tests, 2011-12-15), but it definitely is not necessary > now. That doesn't seem to be an issue in a3e8267225 (or in any other commits touching t6050 since): $ echo foobar | ( ./t6050-replace.sh ; read input ; echo $input ) * ok 1: set up buggy branch * ok 2: replace the author * passed all 2 test(s) foobar
