On 9 May 2018 at 18:19, Duy Nguyen <pclouds@xxxxxxxxx> wrote: > On Tue, May 8, 2018 at 8:18 PM, Jeff King <peff@xxxxxxxx> wrote: >> It should be totally safe. If you look at "struct lock_file", it is now >> simply a pointer to a tempfile allocated on the heap (in fact, I thought >> about getting rid of lock_file entirely, but the diff is noisy and it >> actually has some value as an abstraction over a pure tempfile). > > Ah.. I did miss that "everything on heap" thing. Sorry for the noise > Martin and thanks for clarification Jeff :) Hey, no problem. In fact, the "noise" as you call it had some signal in it: the commit messages should obviously say more about this. Martin
