Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > Besides, your lines are way too long. Yes, it is not in > Documentation/SubmittingPatches,... > ... since you have to read the source to get acquainted > with it _anyway_, it would only be a duplication to have it in > SubmittingPatches, too. Well, maybe we should do this. diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 01354c2..4bdfdfe 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -5,6 +5,7 @@ Checklist (and a short version for the impatient): - make commits of logical units - check for unnecessary whitespace with "git diff --check" before committing + - tab width is 8, the terminal is 80-columns wide. - do not check in commented out code or unneeded files - provide a meaningful commit message - the first line of the commit message should be a short @@ -82,6 +83,14 @@ option). Another thing: NULL pointers shall be written as NULL, not as 0. +(1b) Tab width is 8, Terminal is 80-column wide. + +We generally follow the same coding style guidelines as the +Linux kernel project. Lines are indented with Tabs, each of +which are 8 columns wide. Lines should fit on 80-column wide +terminals. + + (2) Generate your patch using git tools out of your commits. git based diff tools (git, Cogito, and StGIT included) generate - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html