On Sun, May 06, 2018 at 08:07:46PM -0400, Eric Sunshine wrote: > On Sun, May 6, 2018 at 7:17 PM, brian m. carlson > <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: > > Adjust the test so that it computes variables for blobs instead of using > > hard-coded hashes. > > > > Signed-off-by: brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx> > > --- > > diff --git a/t/t4008-diff-break-rewrite.sh b/t/t4008-diff-break-rewrite.sh > > @@ -27,29 +27,32 @@ Further, with -B and -M together, these should turn into two renames. > > + blob0_id=$(git hash-object file0) && > > + blob1_id=$(git hash-object file1) && > > + blob2_id=$(git hash-object file1) && > > + link_oid=$(printf frotz | git hash-object --stdin) && > > Inconsistency nit: For the blobs, you tacked on "_id" but for the link > you added "_oid". Yes, that was intentional. I want them to line up nicely because it makes reading the heredocs much easier. Maybe it would be better if I called it "linkf_id" or "slink_id" or something. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
