On Sun, May 06, 2018 at 02:35:44AM -0400, Jeff King wrote: > You'd have to introduce GIT_COLOR_REVERSE. I don't think we have a > constant for it yet, but it's \x[7m. Heh, of course you knew that already, as I just noticed your patch is using the reverse attribute internally (I had thought at first glance you were just specifying the background independently). So really, I guess all I am arguing for is having GIT_COLOR_INV (or REVERSE) as a constant, and then teaching the code to combine it with the existing "new" color. It's perfectly OK to have: \x1b[7m\x1b[36m instead of: \x1b[7;36m It's two extra bytes, but I doubt anybody cares. -Peff
